Fix: Added lang variable for guide links #1422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UlisesGascon
approved these changes
Nov 25, 2023
There was a problem hiding this comment.
Thanks @SamIsTheFBI! This will improve a lot the UX for the users 👍
dougwilson
force-pushed
the
bugfix-language-change-in-api-reference
branch
from
56a0dbf
to
2e87474
Compare
dougwilson
pushed a commit
to SamIsTheFBI/expressjs.com
that referenced
this pull request
Nov 27, 2023
dougwilson
force-pushed
the
bugfix-language-change-in-api-reference
branch
from
4c34d4a
to
9393f34
Compare
fixes expressjs#1406 closes expressjs#1422
dougwilson
force-pushed
the
bugfix-language-change-in-api-reference
branch
from
9393f34
to
b33766a
Compare
dougwilson
approved these changes
Nov 27, 2023
dougwilson
temporarily deployed
to
github-pages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1406
📝 Description
Prepended
{{page.lang}}to/guide/...links in the markdown files at_includes/api/en/4x/. So, now the correct language shows up in the links & it leads to the correct documentations.The following show the changes at https://expressjs.com/en/api.html#res.render
🖼️ Current behavior
⚡ New behavior
Now, the correct language shows in the link.